refactor(mgr-api): extract extra-fields CRUD into controller - #491
Open
Ibochkarev wants to merge 1 commit into
Open
refactor(mgr-api): extract extra-fields CRUD into controller#491Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Move inline route closures to a Manager controller with DI-backed ExtraFieldsService; routes only dispatch. Adds getField() on the service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
CRUD
/api/mgr/extra-fieldsвынесен из толстых closure вExtraFieldsController. Маршруты только диспатчат в контроллер. СервисExtraFieldsServiceзарегистрирован в DI какms3_extra_fields; добавленgetField()с общимformatField()дляcolumn_exists.Тип изменений
Связанные Issues
Closes #355
Как это было протестировано?
composer test:smoke)Конфигурация тестирования:
feat/issue-355-extra-fields-controllerСкриншоты (если применимо)
Чеклист
Дополнительные заметки
AC #355
manager.phpнетgetObject/ разбора body для extra-fieldsExtraFieldsControllerRoutesTestResponse, те же коды ошибокResponseResponse::*()->getData()php -lВне scope
manager.phpна файлыConfigRoutePermissionsTest)Refs #341, #345