feat(settings): consolidate dual API combo lists, drop member processors - #490
Open
Ibochkarev wants to merge 2 commits into
Open
feat(settings): consolidate dual API combo lists, drop member processors#490Ibochkarev wants to merge 2 commits into
Ibochkarev wants to merge 2 commits into
Conversation
…cessors Share SettingsComboListService between ExtJS combo GetList and Manager REST dropdowns; remove unused Delivery↔Payment membership processors that duplicated Vue REST with hardcoded TODOs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Сводим дублирующую поверхность Settings: ExtJS combo GetList (Delivery/Payment/Vendor) и Manager REST dropdowns читают один
SettingsComboListService. Удалены неиспользуемые processors членства Delivery↔Payment (Enable/Disable/GetList/Multiple) с@TODO: hardcode— Vue уже ходит в REST membership.Добавлен
GET /api/mgr/payments-active(whitelist полей как у deliveries-active). Vendors в ReferencesController тоже через сервис.Тип изменений
Связанные Issues
Closes #346
Как это было протестировано?
composer test:smoke)Конфигурация тестирования:
feat/issue-346-settings-dual-api-restСкриншоты (если применимо)
Чеклист
composer stan/ CI jobPHPStan) — baseline очищен от удалённых Disable; полный stan в CInpm run lint:ciдля Vue) — Vue не трогалиДополнительные заметки
Что сделано по AC #346
combo=trueи REST active/vendors — черезms3_settings_combo_list.Чеклист оставшихся Settings processors (не в этом PR)
ms3.combo.jsВне scope: Status/Link combos, entity Enable/Disable CRUD, gallery/import, смена URL ExtJS combo на REST (adapter через GetList достаточен для «один canonical list»).
Review
resolvePinnedIncludeId