GridConfigService: request-scoped memoize getGridConfig - #488
Open
Ibochkarev wants to merge 3 commits into
Open
Conversation
Cache grid config by gridKey and includeHidden on the service instance, and invalidate entries when grid config is mutated in the same request. Closes #352
Ibochkarev
added
priority: medium
Expand the gridConfigCache docblock to state why the memo is safe only under the DI singleton (one instance per request, no cross-request persistence) and that all four mutation methods invalidate via invalidateGridConfigCache().
Single entry point for cache invalidation before msGridField writes.
Ibochkarev
force-pushed
the
feat/issue-352-grid-config-memo
branch
from
July 29, 2026 17:31
158603f to
e0bbb73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
GridConfigService::getGridConfig()теперь кэширует результат в памяти инстанса сервиса (request-scoped через DI). Повторные вызовы с теми же(gridKey, includeHidden)не делают второйgetCollection(msGridField).Кэш сбрасывается в начале мутаций:
saveGridConfig,addField,updateField,deleteField.Тип изменений
Связанные Issues
Closes #352
Как это было протестировано?
Конфигурация: PHP 8.4.17, branch
feat/issue-352-grid-config-memoЧеклист
getGridConfigс теми же аргументами — один hit в коллекциюsaveGridConfigследующий read идёт в БД (invalidation)