fix(products): дополнительные категории в msProducts и гриде категории - #482
Open
Ibochkarev wants to merge 5 commits into
Open
fix(products): дополнительные категории в msProducts и гриде категории#482Ibochkarev wants to merge 5 commits into
Ibochkarev wants to merge 5 commits into
Conversation
Ibochkarev
force-pushed
the
fix/issue-481-msproducts-additional-categories
branch
from
July 29, 2026 11:37
d5f11d6 to
edaeb0a
Compare
Extract CategoryProductScopeService so msProducts and the category products grid include msCategoryMember links, with regression tests.
Add testable admin WHERE builder, clarify drag-sort for direct children only, and close modx-pro#480 alongside modx-pro#481 in the same PR.
Resolve CategoryProductScopeService from the container only and bump the ms3_products \$services ignore count after the modx-pro#481 wiring.
CategoryProductScopeService::isProductInCategory() has no callers in the codebase (verified by grep across src/, tests/, vueManager/). Remove it to keep the scope surface minimal (modx-pro#481 review).
Ibochkarev
force-pushed
the
fix/issue-481-msproducts-additional-categories
branch
from
July 29, 2026 17:37
cac9fa4 to
28f34e6
Compare
ProductDataController no longer calls removed CategoryProductsListService::isProductInCategoryScope(); delegate to findInCategory() which includes msCategoryMember links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Логика «товары категории = primary parent + msCategoryMember» вынесена в
CategoryProductScopeServiceи подключена к сниппетуmsProductsи админскому гриду товаров категории.Для #480 дополнительно:
buildProductCategoryScopeWhere(), drag-sort черезcanReorderInCategory()(только прямые дочерние; доп. категории видны в гриде, но menuindex им не меняется).Тип изменений
Связанные Issues
Closes #481
Closes #480
Как это было протестировано?
php tests/CategoryProductScopeServiceTest.php— exit 0composer test:smoke— 19/19 OKGate A (#480 + #481)