fix(email): экранирование & в ссылке на заказ в письме менеджеру - #465
Merged
Conversation
Ibochkarev
force-pushed
the
fix/issue-451-email-href-amp
branch
from
July 29, 2026 02:05
44651e0 to
3aff468
Compare
Unescaped & in ms3_email_new_manager.tpl triggered htmlParseEntityRef warnings when modPHPMailer inlines CSS via DOMDocument::loadHTML.
Ibochkarev
force-pushed
the
fix/issue-451-email-href-amp
branch
from
July 29, 2026 11:31
3aff468 to
75de701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
В чанке
ms3_email_new_managerquery string вhrefсодержал литеральные&(&namespace=…&order=…). При отправке письма MODX прогоняет HTML черезInlineStyle→DOMDocument::loadHTML(), libxml выдаётhtmlParseEntityRef: expecting ';'и засоряетerror.log.Исправление:
&→&в атрибутеhref. Добавлен smoke-тест, сканирующий всеms3_email*.tplна неэкранированные&в quotedhref.Тип изменений
Связанные Issues
Closes #451
Как это было протестировано?
Локальный CI-гейт (без MODX/MySQL):
error.logбез warnings — рекомендуется на стенде)composer ci:php)Конфигурация тестирования:
Скриншоты (если применимо)
Чеклист
Дополнительные заметки
ms3_email*.tpl— проблемный href только вms3_email_new_manager.tpl.?a=mgr/orders&order=vs?a=mgr/order&id=— отдельная тема, не входит в scope [Bug] PHP warnings htmlParseEntityRef в письме нового заказа менеджеру (неэкранированные & в URL) #451.