fix(order): повторная проверка fixed после mutation статуса плагином - #464
Open
Ibochkarev wants to merge 1 commit into
Open
fix(order): повторная проверка fixed после mutation статуса плагином#464Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Ibochkarev
force-pushed
the
fix/issue-382-status-fixed-revalidate
branch
from
July 29, 2026 02:05
c30783a to
004c53a
Compare
Extract validateStatusTransition() and run it again after msOnBeforeChangeOrderStatus may change the target status id.
Ibochkarev
force-pushed
the
fix/issue-382-status-fixed-revalidate
branch
from
July 29, 2026 11:31
004c53a to
85467c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
OrderStatusService::change()проверялfixed/finalдоmsOnBeforeChangeOrderStatus, но не после mergereturnedValues['status']. Плагин мог подменить target status на более ранний position и обойти правило.Вынесена
validateStatusTransition(); после перечитывания статуса из mutation правила применяются повторно.Тип изменений
Связанные Issues
Closes #382
Как это было протестировано?
Gate A
validateStatusTransition()после$resolvedStatusId !== $statusIdms3_err_status_fixedOrderStatusFixedRevalidateTest.php