fix(auth): session bypass после revoke API-токенов + Web logout - #462
Open
Ibochkarev wants to merge 2 commits into
Open
fix(auth): session bypass после revoke API-токенов + Web logout#462Ibochkarev wants to merge 2 commits into
Ibochkarev wants to merge 2 commits into
Conversation
16 tasks
Ibochkarev
force-pushed
the
fix/issue-409-token-session-revoke
branch
2 times, most recently
from
July 29, 2026 11:31
542cb7f to
79c3439
Compare
Remove customer_id-only auth in TokenMiddleware and AuthorizedCustomerTrait, add POST /api/v1/customer/logout with token-aware Logout processor, and regenerate session id on logout.
Ibochkarev
force-pushed
the
fix/issue-409-token-session-revoke
branch
from
August 1, 2026 09:37
79c3439 to
9fffbb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
TokenMiddlewareпропускал non-public запросы по одному$_SESSION['ms3']['customer_id']без проверки API-токена в БД. После revoke на одном устройстве другое с живой PHP-сессией сохраняло доступ. В Web REST не былоPOST /api/v1/customer/logout, хотя процессор уже существовал.Исправление:
customer_tokenиз session проходит DB-валидацию;customer_idбез токена очищается черезclearClientTokenState();AuthorizedCustomerTrait— только customer черезresolveApiToken();POST /api/v1/customer/logout→Logoutprocessor сTokenMiddleware, public route;revokeTokens, anonymous token,session_regenerate_id(true).Тип изменений
Связанные Issues
Closes #409
Как это было протестировано?
Чеклист
Дополнительные заметки
Deferred (follow-up): snippet-слой
ms3_customer/CustomerPageServiceвсё ещё может опираться на sessioncustomer_id;CustomerProfileController/CustomerEmailControllerчитают session напрямую (middleware на их роутах уже синхронизирует session после валидации токена).