fix(order): единая база для процентной комиссии оплаты (cart-only) - #460
Open
Ibochkarev wants to merge 1 commit into
Open
fix(order): единая база для процентной комиссии оплаты (cart-only)#460Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Ibochkarev
force-pushed
the
fix/issue-372-payment-fee-base
branch
from
July 29, 2026 02:05
057df7e to
7cc0028
Compare
Manager recalculate used cart+delivery for percent fees while storefront used cart only. Shared OrderService::paymentCommissionBase() keeps both paths consistent.
Ibochkarev
force-pushed
the
fix/issue-372-payment-fee-base
branch
from
July 29, 2026 11:32
7cc0028 to
b77555b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Процентная комиссия оплаты считалась по разным базам: storefront — только от
cart_cost, пересчёт в менеджере — отcart_cost + delivery_cost. При корзине 1000, доставке 500 иprice=3%на сайте получалось ~30, в mgr ~45.Добавлен общий контракт
OrderService::paymentCommissionBase()(как в MS2: только корзина). Storefront иManagerOrderCostRecalculatorиспользуют один helper.Тип изменений
Связанные Issues
Closes #372
Как это было протестировано?
composer ci:php)Конфигурация тестирования:
Скриншоты (если применимо)
n/a
Чеклист
npm run lint:ciдля Vue) — Vue не затронутДополнительные заметки
Продуктовое решение: cart-only (совместимость с MS2 и текущим storefront). Заказы, уже пересчитанные в mgr с базой cart+delivery, при следующем Recalculate cost получат сумму как на сайте.