Repository navigation
Propose to improve Puzzles 15, 16, 17 - #273
Open
tolgacangoz wants to merge 6 commits into
Open
tolgacangoz wants to merge 6 commits into
tolgacangoz wants to merge 6 commits into
Conversation
tolgacangoz
commented
Oct 22, 2026
Comment on lines
-171
to
-188
| while stride > 0: | ||
| var temp_val: Scalar[dtype] = 0 | ||
| if local_i < stride: | ||
| temp_val = cache[local_i + stride] # Read phase | ||
| barrier() | ||
| if local_i < stride: | ||
| cache[local_i] += temp_val # Write phase | ||
| barrier() | ||
| stride //= 2 | ||
| ``` | ||
|
|
||
| **Note**: The read and write phases are deliberately separated by a | ||
| `barrier()`. The simpler form below reads and writes shared memory in the | ||
| same iteration, which races: | ||
|
|
||
| ```mojo | ||
| # Racy - do not use | ||
| var stride = TPB // 2 |
Contributor
Author
There was a problem hiding this comment.
Aren't reading and writing independent?
tolgacangoz
changed the title
15, 16, 17
tolgacangoz
force-pushed
the
errata-1
branch
3 times, most recently
from
October 27, 2026 06:38
8108b33 to
c916007
Compare
… revise tutorial references for better guidance.
Use to_tile_tensor for the kernel arguments, pass device to ops.custom, and show mojo precompile in the packaging example.
The puzzle tasks and the skeleton compile script now use the current command name.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this implementation based educational site!
Proposing to fix race condition argument, improve documentation, and update examples.
@ehsanmok @dunnoconnor @KenJones-Modular @ansley