Skip to content

Find validation scope owners without building chains #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Nov 3, 2026
Merged

Find validation scope owners without building chains #744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion modern_di/dependency_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,25 @@ def find_cycle_from(
return None


def _find_scope_owner(
provider: AbstractProvider[typing.Any], registry: "ProvidersRegistry"
) -> AbstractProvider[typing.Any]:
"""Follow aliases and derived sources to the scope owner."""
seen: set[int] = set()
while True:
if type(provider) is _Derived:
provider = provider._source # noqa: SLF001
seen.clear()
elif type(provider) is Alias:
target = redirect_target(provider, registry)
if target is None or provider.provider_id in seen:
return provider
seen.add(provider.provider_id)
provider = target
else:
return provider


def _scope_owner(
provider: AbstractProvider[typing.Any],
registry: "ProvidersRegistry",
Expand All @@ -223,7 +242,7 @@ def _scope_owner(
provider_id = provider.provider_id
owner = scope_owners.get(provider_id)
if owner is None:
owner = scope_chain(provider, registry)[-1]
owner = _find_scope_owner(provider, registry)
scope_owners[provider_id] = owner
return owner

Expand Down
Loading