Repository navigation
Match derived OpenTelemetry exclusions against ASGI route paths - #416
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #392.
FastAPI and FastMCP match derived OpenTelemetry exclusions against the ASGI route path, accounting for root_path. Configured and environment URL regexes retain their existing behavior.
Both FastAPI regressions failed before the fix and now pass. A slash in Host no longer hides a work request from tracing, and health checks under /api stay excluded. Raw HTTP probes confirmed that Uvicorn 0.54.0 with h11 and httptools, and Hypercorn 0.18.0, pass the slash-containing Host header through.
Local verification passed with 620 tests, 100% coverage, lint, and type checking.