Repository navigation
Restore root logger state on logging teardown - #415
Merged
Merged
Conversation
Fixes #388 ## Breaking changes Logging teardown preserves other root handlers and restores the root level from before bootstrap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #388.
Logging teardown closes and removes the handler installed by the instrument and restores the root logger level from before bootstrap. The docs explain that
logging_unset_handlersremovals are permanent.Breaking changes
Teardown preserves other root handlers and restores the previous root level.
Verification
just test-cipassed with 618 tests and 100% coverage.just lint-cipassed, including type checking.