Repository navigation
Preserve stored structlog exceptions in Sentry events - #414
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #390.
Pass the original
exc_infoto stdlib logging alongside the rendered JSON line. This lets Sentry capture the stored exception and its stack trace outside anexceptblock while keeping the traceback on stdout.The regression checks the captured Sentry envelope and the JSON line on stdout. It failed before the fix because the envelope had no exception.
Validation passed with
just lint-ciandjust test-ci(617 tests, 100% coverage).