Repository navigation
fix(fastapi)!: tear down after user lifespan shutdown - #412
Merged
Merged
Conversation
Closes #384 BREAKING CHANGE: lite-bootstrap tears down FastAPI observability after the user lifespan shutdown runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #384.
Replace FastAPI's private lifespan merger with a local context manager. The regression verifies that a user shutdown span is exported and that user lifespan state still reaches request handlers.
Litestar already runs user shutdown first. The FastMCP ordering bug is tracked in #411.
All 615 tests passed with 100% coverage. Lint and type checking passed.
Breaking changes
Lite-bootstrap tears down FastAPI observability after the user's lifespan shutdown code runs.