Repository navigation
Roll back failed bootstrap and fix Sentry route naming and Swagger typing - #406
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When instrument startup or application preparation raises, including KeyboardInterrupt or SystemExit, roll back only successfully started instruments in reverse order. Preserve the original failure with ordinary cleanup errors attached as notes, leave the bootstrapper unbootstrapped, and reject reuse after failure. Document the terminal failure contract.
Fix FastMCP lean Sentry transaction naming by assigning names in one place: preserve existing names, otherwise resolve full matched route templates through Mount and Host containers. Stop at the first full match, including opaque routes, and use scope route metadata only when no route tree was supplied. This covers newer Starlette versions that populate scope["route"] themselves.
Also specialize the Swagger instrument config in its typing test.
Closes #382.
Validation
just install, matching CI's upgrade recipe.just test-ci: 604 passed, 100% coverage.just lint-ci: passed, including repository-wide ty.