Skip to content

fix: skip the unencrypted-OTLP warning for https gRPC endpoints #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Oct 28, 2026
Merged

fix: skip the unencrypted-OTLP warning for https gRPC endpoints #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lite_bootstrap/instruments/opentelemetry_instrument.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ def _parse_remote_insecure_host(self, endpoint: str | None) -> str | None:
if "://" not in raw:
raw = f"//{raw}"
parsed = urllib.parse.urlparse(raw)
# The gRPC exporter forces TLS for https whatever insecure says.
if parsed.scheme == "https":
return None
host = (parsed.hostname or "").lower()
if host in _LOCAL_HOSTS:
return None
Expand Down
7 changes: 7 additions & 0 deletions tests/instruments/test_opentelemetry_instrument.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,13 @@ def test_opentelemetry_config_no_warning_for_local_endpoints(endpoint: str) -> N
OpenTelemetryConfig(opentelemetry_endpoint=endpoint, opentelemetry_insecure=True)


@pytest.mark.parametrize("endpoint", ["https://collector.example.com:4317", "HTTPS://collector.example.com:4317"])
def test_opentelemetry_config_no_warning_for_https_endpoints(endpoint: str) -> None:
with warnings.catch_warnings():
warnings.simplefilter("error")
OpenTelemetryConfig(opentelemetry_endpoint=endpoint, opentelemetry_metrics_endpoint=endpoint)


@pytest.mark.parametrize(
"endpoint",
[
Expand Down
Loading