Repository navigation
fix: preserve Kafka telemetry spans during concurrent processing - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FastStream can run telemetry cleanup after concurrent dispatch returns, before the background task starts or finishes. This can leave the Kafka consumer process span unexported or end it too early.
During FastStream application startup,
initialize_concurrent_processing()automatically adapts existing FastStreamKafkaTelemetryMiddlewareregistrations that followKafkaConcurrentProcessingMiddleware. The adapter preserves middleware order and telemetry settings, and ends the process span after both consume execution and middleware cleanup finish.Downstream services using this setup only need to upgrade
faststream-concurrent-aiokafka. They keep their existing middleware registrations and OpenTelemetry dependencies. The base package still works without OpenTelemetry.Validation