Repository navigation
Conversation
Passes TrainConfig.dp_balance to twinkle's TransformersModel, which by default reorders each Ray slice_dp batch so the DP ranks get similar workloads. --dp_balance false turns it off. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Depends on modelscope/twinkle#367; merge that first.
twinkle's
TransformersModelnow balances the DP workload by default. This PR adds a switch for it:TrainConfig.dp_balance(defaultTrue);--dp_balance falseturns it off.builders/model.pypasses it to the twinkleTransformersModelconstructor.