Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Keep memory tools inside the orchestrator's existing store-ownership lifecycle.
MemoryTooldelegates tohandle_tool_call, but that path previously bypassed the store lock and terminal-close check. A late tool could restart a closed backend and changeMEMORY.md, or overlap another store operation and teardown.Related issue number
No existing issue is being closed. This completes the memory-tool path under the terminal-close/store-serialization contract introduced in #943; it does not change #1026's facts cache handling.
Validation
MemoryTool,MemoryOrchestrator, and the file backend: baseline 7 failures / 2 passes; final 9 passes.python -m pytest tests/memory -q: final 188 passed, 74 skipped, 3 failed. With the identical tests on untouched source: 181 passed, 74 skipped, 10 failed. The three common failures require an unavailable ModelScope remote fixture or API-key configuration; no live provider testing is claimed.Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check.