Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Make Han keywords searchable inside unspaced descriptions in the lightweight BM25 retriever used by default skill discovery. A local skill described as 用于分析销售数据并生成报表 is not found by 销售数据; CSV cannot match 使用Python3处理CSV文件. Reproduced through the real SkillCatalog and default SkillSearchEngine, without retriever/model mocks.
Split BMP Han and Extension A characters individually, preserving other Unicode word runs, case normalization, digits and underscores. No dependency, model download, configuration or public API is added. Standalone BM25 and default/hybrid sparse skill search are affected; legacy hybrid_retriever.py is unchanged.
This is a character-level bag of words, not word segmentation or semantic retrieval. Partial single-character matches can increase; word order is not modeled. Shared-character distractor ranking is covered by a regression fixture, not a general quality benchmark.
Related issue number
No duplicate found in all-state BM25/CJK/Chinese token searches. #975 is unrelated cache invalidation.
Validation
Python 3.12.14 with normal SDK dependencies.
Not run: full repository suite, live Agent/LLM calls, browser UI, other Python/platform versions. Broad existing skill tests include network-backed downloads; new regressions are offline.
Checklist
AI assistance: implemented and tested with OpenAI Codex; automated review, no human-review attestation. Draft, no reviewer request.