Skip to content

Add option to specify an ordering constraint for domain sampling points of rectilinear grids - #64

Merged
masoud-najafi merged 2 commits into
modelica:mainfrom
klausschuch:pu/klausschuch/orderingConstraint
Oct 21, 2026
Merged

masoud-najafi merged 2 commits into
modelica:mainfrom
klausschuch:pu/klausschuch/orderingConstraint

Conversation

@klausschuch

@klausschuch klausschuch commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

fixes #60

I wanted to just add an attribute but that seems to be in conflict with the Terminal schema.
Hence, I had to add an annotation.

@chrbertsch
chrbertsch requested review from pmai and t-sommer September 29, 2026 11:00
@klausschuch klausschuch changed the title Add option to specify an ordering constraint for domain sampling points Add option to specify an ordering constraint for domain sampling points of rectilinear grids Sep 29, 2026

@chrbertsch chrbertsch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@masoud-najafi

Copy link
Copy Markdown
Contributor

My only question is why it is defined as an annotation. Annotations can be ignored, so they should not affect the result.

@chrbertsch

Copy link
Copy Markdown
Collaborator

My only question is why it is defined as an annotation. Annotations can be ignored, so they should not affect the result.

As Klaus mentioned, additional attributes are not possible on Terminals.
A Layered Standard can demand the presence of certain annotations.
In the case herber the FMU can be simulated (even without knowing FMI-LS-STRUCT) by just using the underlying arrays

@masoud-najafi
masoud-najafi merged commit 9d8795c into modelica:main Oct 21, 2026
2 checks passed
@klausschuch
klausschuch deleted the pu/klausschuch/orderingConstraint branch October 27, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add restrictions on domain variables

3 participants