Repository navigation
Units in examples and components - #4820
Open
henrikt-ma wants to merge 2 commits into
Open
henrikt-ma wants to merge 2 commits into
henrikt-ma wants to merge 2 commits into
Conversation
henrikt-ma
added
the
requires Modelica 3.7
henrikt-ma
added
L: Electrical.Analog
Contributor
|
Why is the list of possible reviewers so short? |
Contributor
Author
Is there a misunderstanding regarding currently requested reviews and from whom it is possible to request a review? I just assigned the project leaders, because I think the topic of how to address unit inconsistencies like these is bigger than any particular sub-library. |
- Thyristor: the control voltage ramps from 0 to 10*vAK over 1 mA of gate current, now written 10*vAK*(iGK-0.95*IGT)/1e-3'A'. - DCPM_Drive: the battery resistance gives a 5 % voltage drop at 1000 A, now written 0.05*dcpmData.VaNominal/1000'A'. - ShowTransferFunction: the logarithm is taken of the frequency in rad/s, now written log10(logFrequencySweep.y/1'rad/s'). - Surfaces: the temperature oscillates at 0.5 Hz, now written cos(2*Modelica.Constants.pi*0.5'Hz'*time). - GasForce2: the fitted pressure curve is in bar, scaled with 1e5'Pa'. - WaterIF97: the pressure and temperature ramps are written 1e5'Pa'*(1 + time/1's') and 300'K' + 200'K/s' * time. - ElectroMagneticConverterWithLeakageInductance: eps is a minimum current, so that L_stat has the same unit in both branches. The values are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The capacitances c2 and c4 resonate with l1 and l2 at the normalized angular frequencies of the filter's transmission zeros, now written 1.704992'rad/s' and 1.179945'rad/s'. In CauerLowPassOPV and CauerLowPassSC, l1 and l2 are capacitances standing for the inductances l1*R^2 with R = 1 Ohm, so the factor 1'Ohm2' is included. The values are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
beutlich
force-pushed
the
units-in-examples-and-components
branch
from
October 20, 2026 20:45
381bd89 to
04017ff
Compare
Contributor
|
IMHO units should be handled this way. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #4819, but for a variety of small problems across many sub-libraries.