Skip to content

Nice wheel icon - #4715

Open
HansOlsson wants to merge 3 commits into
modelica:masterfrom
HansOlsson:ImproveTire
Open

HansOlsson wants to merge 3 commits into
modelica:masterfrom
HansOlsson:ImproveTire

Conversation

@HansOlsson

Copy link
Copy Markdown
Contributor

The change (apart from nicer formatting) is that the cylinder going into the wheel is ends 1mm to the left.

Previously it looked as if it was in front of the wheel (when looking at the entire icon - in small scale it doesn't matter). The gradient-part was not changed.

Split off from #4711

…nto the wheel is ends 1mm to the left.

Previously it looked as if it was in front of the wheel (when looking at the entire icon - in small scale it doesn't matter).
The gradient-part was not changed.

Split off from modelica#4711
@HansOlsson HansOlsson added L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody icon Issues addresses the icon graphics labels Dec 10, 2025
Comment thread Modelica/Mechanics/MultiBody/Visualizers/VoluminousWheel.mo Outdated
Co-authored-by: Malte Lenz <malte.lenz@gmail.com>
@HansOlsson HansOlsson added this to the MSL4.2.0 milestone Oct 26, 2026
@MartinOtter

Copy link
Copy Markdown
Member

Please add images of your changes.
I could compare MSL

grafik

the the propopsal from Hans:

grafik

But don't see a difference. I would accept the change from Hans, if he thinks its better

I don't manage to open MSL with the proposed change from maltelenz and don't want to spend time to figure this out. Please, provide a screenshot of your proposed change and explain why it looks better as the proposal from Hans.

@HansOlsson

Copy link
Copy Markdown
Contributor Author

Please add images of your changes. I could compare MSL

grafik

I added two circles to show the issue:

AA

the the propopsal from Hans:

grafik But don't see a difference. I would accept the change from Hans, if he thinks its better

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icon Issues addresses the icon graphics L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants