Skip to content

Add a simpler pump - #4149

Open
HansOlsson wants to merge 7 commits into
modelica:masterfrom
HansOlsson:SimplerPump
Open

Add a simpler pump#4149
HansOlsson wants to merge 7 commits into
modelica:masterfrom
HansOlsson:SimplerPump

Conversation

@HansOlsson

@HansOlsson HansOlsson commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Closes #2413

As described in #2413 the idea is to have an even simpler Pump when we don't care about N, efficiency and pump characteristics.

@HansOlsson
HansOlsson requested a review from casella June 13, 2023 11:59
@HansOlsson

HansOlsson commented Jun 13, 2023

Copy link
Copy Markdown
Contributor Author

@sjoelund I don't understand why C-Sources cannot be built for something that didn't change them.

@casella

casella commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

Will look into it ASAP, I'm overbooked now.

@sjoelund

sjoelund commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member 
java.io.IOException: Failed to kill container '3fb88ac4d9f4dc9472b40d83e6a3120bdf9b91476fec41468d39fac9a60011ed'.
	at org.jenkinsci.plugins.docker.workflow.client.DockerClient.stop(DockerClient.java:187)

Should work when I rerun it...

@beutlich beutlich added enhancement New feature or enhancement L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) labels Jul 2, 2023
@beutlich beutlich changed the title Add a simpler Pump. Add a simpler pump Jul 2, 2023
@HansOlsson
HansOlsson requested a review from hubertus65 August 7, 2023 14:32
beutlich
beutlich previously requested changes Jan 14, 2024
View reviewed changes

@beutlich beutlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required file comparisonSignals.txt is missing for the new example SimplerHeatingSystem. (Unfortunately we have no CI check for it though I tried it some years ago).

Comment thread Modelica/Fluid/Examples/Explanatory.mo Outdated
HansOlsson
HansOlsson commented Jan 15, 2024
View reviewed changes
Comment thread Modelica/Fluid/Examples/Explanatory.mo Outdated
@HansOlsson

HansOlsson commented Jan 15, 2024

Copy link
Copy Markdown
Contributor Author

The required file comparisonSignals.txt is missing for the new example SimplerHeatingSystem. (Unfortunately we have no CI check for it though I tried it some years ago).

Added (well, copied to be correct).

beutlich
beutlich reviewed Jan 15, 2024
View reviewed changes
Comment thread Modelica/Fluid/Machines.mo Outdated
hubertus65
hubertus65 approved these changes Jan 16, 2024
View reviewed changes

@hubertus65 hubertus65 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in Modelon Impact and looks ok. In terms of user friendliness for beginners: this is pretty complex.

@beutlich
beutlich dismissed their stale review January 17, 2024 09:52

Resolved

tobolar
tobolar reviewed Jan 17, 2024
View reviewed changes
Comment thread Modelica/Fluid/Machines.mo Outdated
tobolar
tobolar reviewed Jan 17, 2024
View reviewed changes
Comment thread Modelica/Fluid/Machines.mo
HansOlsson and others added 5 commits March 18, 2025 21:07
@HansOlsson @beutlich
Add a simpler Pump.
173a826 
Closes modelica#2413
@HansOlsson @beutlich
Update Modelica/Fluid/Examples/Explanatory.mo
c384baa
@HansOlsson @beutlich
Add comparison signals.
a636274
@HansOlsson @beutlich
Use Dialog.enable and have usual description text.
f7ed782 
Note that this is a protected parameter so it is only shown for base-classes.
I decided to have the conditions both as description and as Dialog.enable
to make it understandable.
@HansOlsson @tobolar @beutlich
Update Modelica/Fluid/Machines.mo
334c427 
Co-authored-by: tobolar <tobolar@users.noreply.github.com>
@beutlich

beutlich commented Mar 18, 2025

Copy link
Copy Markdown
Member

@sjoelund I don't understand why C-Sources cannot be built for something that didn't change them.

CI environments are variant systems themselves.

@beutlich

beutlich commented Mar 18, 2025

Copy link
Copy Markdown
Member

Will look into it ASAP, I'm overbooked now.

@casella Did you find some time to check this meanwhile?

@beutlich

beutlich commented Mar 18, 2025

Copy link
Copy Markdown
Member

@justnielsen FYI

beutlich
beutlich reviewed Mar 18, 2025
View reviewed changes
Comment thread ...ces/Reference/Modelica/Fluid/Examples/Explanatory/SimplerHeatingSystem/comparisonSignals.txt
Comment thread Modelica/Fluid/Examples/Explanatory.mo
HansOlsson and others added 2 commits March 19, 2025 08:55
@HansOlsson @beutlich
Update Modelica/Resources/Reference/Modelica/Fluid/Examples/Explanato…
786119f 
…ry/SimplerHeatingSystem/comparisonSignals.txt

Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
@HansOlsson
Merge branch 'master' into SimplerPump
031ec1b

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobolar tobolar tobolar left review comments
@beutlich beutlich beutlich left review comments
@hubertus65 hubertus65 hubertus65 approved these changes
@casella casella Awaiting requested review from casella

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or enhancement L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simpler Modelica.Fluid.Machines.ControlledPump

6 participants

@HansOlsson @casella @sjoelund @beutlich @tobolar @hubertus65