Battery model removed from MSL 4.1 and no conversion script #4717

Activity

1. Walshest commented on Jan 2, 2026

   

   Walshest

   on Jan 2, 2026

   Author

   More actions

   @christiankral Would you be able to look at this and either provide a conversion or return the model?
2. christiankral commented on Jan 2, 2026

   

   christiankral

   on Jan 2, 2026

   Contributor

   More actions

   It think we have two aspects here:

   1. The battery model Modelica.Electrical.Machines.Examples.ControlledDCDrives.Utilities.Battery solely consisted of a constant voltage source and a constant internal resistance. So there is no real "need" for such a model. @AHaumer I guess is the reason why this model has been removed.
   2. The package Modelica.Electrical.Batteries has been added. The battery models provided in this package allow a lot of flexibility in considering battery behavior. So there was no need to keep the simple battery model in the Examples package of Machines.

   👍React with 👍1Reacted by Stefan Walshe
3. christiankral commented on Jan 2, 2026

   

   christiankral

   on Jan 2, 2026

   Contributor

   More actions

   On my opinion a conversion script is not required as models provided in an Examples package may be modified or removed anytime.
4. Walshest commented on Jan 2, 2026

   

   Walshest

   on Jan 2, 2026

   Author

   More actions

   On my opinion a conversion script is not required as models provided in an Examples package may be modified or removed anytime.

   Thanks for the quick feedback.
   As this is a component model w/in an Examples folder, then I think a conversion script should have been available.

   However as you mentioned it was a very simple component. I have duplicated it from the MSL 4.0 and inserted into our own internal library and our models work again.

   Regards,
   Stefan
5. beutlich

   added

   wontfixIssue that will not be fixedIssue that will not be fixed

   exampleIssue only addresses example(s)Issue only addresses example(s)

   L: Electrical.MachinesIssue addresses Modelica.Electrical.MachinesIssue addresses Modelica.Electrical.Machines

   on Jan 2, 2026
6. beutlich commented on Jan 2, 2026

   

   beutlich

   on Jan 2, 2026

   Member

   More actions

   On my opinion a conversion script is not required as models provided in an Examples package may be modified or removed anytime.

   Thatis correct.
7. beutlich

   closed this as not plannedon Jan 2, 2026
8. beutlich

   added this to the never milestone on Jan 2, 2026
9. AHaumer commented on Jan 2, 2026

   

   AHaumer

   on Jan 2, 2026

   Last edited by AHaumer

   Contributor

   More actions

   Thanks for the explanation @christiankral
   In 2022 @dietmarw suggested to remove the battery model (consisting of a contant voltage source and an inner resistance) to avoid confusion with the Modelica.Electrical.Batteries package.
   The "battery" model was part of the examples package - so no conversions script needed.
   @Walshest for your convenience you'll find attached the zipped "old" battery model.

   Battery.zip
10. HansOlsson commented on Jan 7, 2026

    

    HansOlsson

    on Jan 7, 2026

    Contributor

    More actions

    On my opinion a conversion script is not required as models provided in an Examples package may be modified or removed anytime.

    Thatis correct.

    And included in #4698