fix(client): serialize response cache invalidation - #2688
Open
tandede wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 8ec0121 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResponseCacheStore.set()cannot restore stale data after invalidationlist_changedorresources/updatedinvalidation remain cached@modelcontextprotocol/clientWhy
ResponseCacheStorepermits asynchronous implementations. The existing generation check prevents a response that was already stale beforewrite()from being stored, but it cannot stop an invalidation that arrives whilestore.set()is already pending:write()passes the generation check and enters an asynchronousset().delete()before that set has applied anything.Serializing mutations for each logical cache key makes the earlier set finish before its invalidation delete. A fresh write invoked after that invalidation queues behind the delete, so it is not removed.
Test plan
pnpm --filter @modelcontextprotocol/client test(806 passed)pnpm typecheck:allpnpm lint:allpnpm build:all