fix(core): merge request headers case-insensitively - #2687
Open
uczltw6 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: a10cb78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestInitheaders case-insensitively.Authorizationoverrides and a patch changeset for the affected packages.Root cause
createFetchWithInit()merged normalized header objects with object spread. HTTP field names are case-insensitive, but JavaScript object keys are not. A baseAuthorization: Bearer base-tokenand a per-requestauthorization: Bearer request-tokentherefore both survived the merge; constructing the finalHeaderscombined them into the invalid valueBearer base-token, Bearer request-token.The client Streamable HTTP and legacy SSE transports both use this helper to combine caller-provided
requestInitwith SDK request headers, so request-specific credentials must replace the base header regardless of casing.Validation
@modelcontextprotocol/core-internal: 69 test files, 1448 tests passed.AI assistance disclosure: OpenAI Codex helped identify the header-merge edge case and prepare the focused implementation and test. The production call paths, behavior, and test results were verified locally.