Fix release script skipping version bump for lockfile-only changes#3969
Open
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix release script skipping version bump for lockfile-only changes#3969Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
has_changes() filtered changed files to only .py and .ts suffixes, so packages with only lockfile updates (e.g. uv.lock from dependabot) were never version-bumped. Remove the suffix filter so any file change in a package directory triggers the CalVer bump. Closes modelcontextprotocol#3870 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_changes()inscripts/release.pyonly considered.pyand.tsfiles when deciding whether a package needs a version bump. Packages with only lockfile changes (e.g.uv.lockfrom dependabot) were silently skipped, leaving stale versions inpyproject.toml.scripts/test_release.pywith unit tests forhas_changes(), including a regression test for the lockfile-only scenario.Closes #3870
Test plan
python scripts/test_release.pypasses (4 tests: no changes, .py change, lockfile-only change, .toml change)