Skip to content

fix: avoid shell interpretation in MCP dev launcher - #3371

Closed
KevinTran3011 wants to merge 1 commit into
modelcontextprotocol:mainfrom
KevinTran3011:security/codeql-research-findings
Closed

fix: avoid shell interpretation in MCP dev launcher#3371
KevinTran3011 wants to merge 1 commit into
modelcontextprotocol:mainfrom
KevinTran3011:security/codeql-research-findings

Conversation

@KevinTran3011

Copy link
Copy Markdown

Fixes #

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I am assigned to the linked issue (or it is labeled help wanted, or I'm a maintainer)
  • I have disclosed any AI assistance and can explain the change in my own words
  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Aug 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution. This repository only keeps pull requests open when they're linked to an issue that a maintainer has assigned to the author — CONTRIBUTING.md explains why and how we work. This PR has been closed for now because its description doesn't yet link an open issue in this repository (with Fixes #123 or similar).

If there isn't an issue for this yet, please open one — a clear description of the problem is genuinely the most useful thing for us. Then add Fixes #<number> to this PR's description. If a maintainer would like the change as a PR from you, they'll assign you to the issue and this PR will reopen automatically.

There's no need to open a new PR — this one will be reopened. While it's closed, please push any updates as new commits rather than force-pushing, since GitHub can't reopen a PR whose branch has been rewritten.

Maintainers: reopening this PR, removing the missing-issue-link label, or adding bypass-issue-check bypasses the check.

@github-actions github-actions Bot closed this Aug 24, 2026
@KevinTran3011

Copy link
Copy Markdown
Author

Research note: the custom query found CWE-78/CWE-94 shell interpretation in the Windows MCP Inspector launcher. The code supplied an argv list but set shell=True on Windows (and used shell=True while probing npx), allowing cmd.exe parsing of argument data. The patch keeps the platform-specific npx executable selection but always uses shell=False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant