Fix ClientSession swallowing exceptions in default message_handler - #3366
Fix ClientSession swallowing exceptions in default message_handler#3366mayuriphad wants to merge 1 commit into
Conversation
|
Thanks for the contribution. This repository only keeps pull requests open when they're linked to an issue that a maintainer has assigned to the author — CONTRIBUTING.md explains why and how we work. This PR has been closed for now because you aren't currently assigned to #1401. If a maintainer would like this change as a PR from you, they'll assign you to #1401 and this PR will reopen automatically — there's nothing more you need to do. (If you opened the issue, this PR already shows up on its timeline.) There's no need to open a new PR — this one will be reopened. While it's closed, please push any updates as new commits rather than force-pushing, since GitHub can't reopen a PR whose branch has been rewritten. Maintainers: reopening this PR, removing the |
Fixes #1401 by raising \Exception\ messages passed into the default \message_handler\ instead of swallowing them. This ensures stream errors propagate out of the \ClientSession\ by default.