Skip to content

chore(deps): bump the other-dependencies group across 4 directories with 3 updates #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devcrocod merged 1 commit into from
Sep 29, 2026
Merged

chore(deps): bump the other-dependencies group across 4 directories with 3 updates #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/kotlin-mcp-server/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
kotlin = "2.4.20"
ktor = "3.6.0"
mcp-kotlin = "0.15.0"
slf4j = "2.0.19"
slf4j = "2.0.20"
shadow = "9.6.1"

[libraries]
Expand Down
Binary file modified samples/kotlin-mcp-server/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion samples/kotlin-mcp-server/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.7.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.0-bin.zip
networkTimeout=10000
retries=0
retryBackOffMs=500
Expand Down
52 changes: 41 additions & 11 deletions samples/kotlin-mcp-server/gradlew.bat
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion samples/kotlinlang-mcp-server/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ktor = "3.6.0"
mcp-kotlin = "0.15.0"
serialization = "1.11.0"
coroutines = "1.11.0"
logback = "1.6.3"
logback = "1.6.4"

@jetbrains-air jetbrains-air Bot Sep 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: kotlinlang-mcp-server is the only directory this PR touches that no workflow builds. .github/workflows/samples.yml hardcodes its matrix as kotlin-mcp-client, kotlin-mcp-server, simple-streamable-server, weather-stdio-server, while Dependabot's /samples/* glob updates all five samples. The four green Build Sample checks on this PR therefore cover three of the four changed directories — this one is unverified.

Failure scenario: the logback 1.6.3 → 1.6.4 bump here (and the Gradle 9.8.0 wrapper bump beside it) merges without ever compiling this sample or running its nine test classes. When a future bump in this group does break it, the PR still goes green and the sample stays broken until someone clones it and runs ./gradlew build by hand.

Suggested fix: add kotlinlang-mcp-server to the matrix.sample list in .github/workflows/samples.yml, so every sample directory Dependabot updates is also built.

Produced by Air Automations. Name: Code review / Run: https://air.jetbrains.cloud/org/05cf1a7f-6ab5-713b-abd3-29d0c8a05e2d/automations/409567ec-d3a7-40ac-ba95-8518ec577ac2?run=c34d73ec-ad54-48fd-b2f6-609e6f656614

shadow = "9.6.1"

[libraries]
Expand Down
Binary file modified samples/kotlinlang-mcp-server/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion samples/kotlinlang-mcp-server/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.7.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.0-bin.zip
networkTimeout=10000
retries=0
retryBackOffMs=500
Expand Down
52 changes: 41 additions & 11 deletions samples/kotlinlang-mcp-server/gradlew.bat
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion samples/simple-streamable-server/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kotlin = "2.4.20"
ktor = "3.6.0"
junit = "6.1.3"
mcp-kotlin = "0.15.0"
slf4j = "2.0.19"
slf4j = "2.0.20"
shadow = "9.6.1"

[libraries]
Expand Down
Binary file modified samples/simple-streamable-server/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion samples/simple-streamable-server/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.7.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.0-bin.zip
networkTimeout=10000
retries=0
retryBackOffMs=500
Expand Down
52 changes: 41 additions & 11 deletions samples/simple-streamable-server/gradlew.bat
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion samples/weather-stdio-server/gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ktor = "3.6.0"
logging = "8.0.4"
mcp-kotlin = "0.15.0"
shadow = "9.6.1"
slf4j = "2.0.19"
slf4j = "2.0.20"

[libraries]
kotlin-logging = { group = "io.github.oshai", name = "kotlin-logging-jvm", version.ref = "logging" }
Expand Down
Binary file modified samples/weather-stdio-server/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion samples/weather-stdio-server/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.7.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.0-bin.zip
networkTimeout=10000
retries=0
retryBackOffMs=500
Expand Down
Loading
Loading