Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough정착 그룹 관련 타입·API·훅을 추가하고 Home 섹션을 API 기반으로 전환했으며, 결제 승인/거절 타입·API·훅을 추가하고 PaymentManagement 페이지에서 이를 호출하도록 연결했습니다. Changes
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📝 관련 이슈 |
Deploying moddo-frontend with
|
| Latest commit: |
496a5f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4c24d93b.moddo-frontend.pages.dev |
| Branch Preview URL: | https://md-29.moddo-frontend.pages.dev |
Contributor
Author
|
@coderabbitai 리뷰해줘 |
|
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
src/pages/home/ui/HomePageSection/index.tsx (2)
121-123: 로딩 상태 처리를 고려해 보세요.현재 데이터 로딩 중에는
settlementList가 빈 배열이 되어 "정산이 없어요" 메시지가 잠시 표시됩니다.isLoading상태를 활용하여 로딩 인디케이터를 표시하면 UX가 개선됩니다.💡 로딩 상태 처리 예시
const sort = sortToggle ? 'OLDEST' : 'LATEST'; - const { data } = useGetSettlementList(settlementType, sort); + const { data, isLoading } = useGetSettlementList(settlementType, sort); const settlementList = data ?? [];그 후 렌더링 부분에서
isLoading상태에 따라 스켈레톤 UI나 스피너를 표시할 수 있습니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/home/ui/HomePageSection/index.tsx` around lines 121 - 123, The component treats data absence as an empty list, causing the "no settlements" message to flash during fetch; update the call to useGetSettlementList(sort) to also read its isLoading (or isFetching) flag and use that to control UI: keep settlementList = data ?? [] but in the render branch show a loading indicator/skeleton when isLoading is true (instead of showing the "정산이 없어요" empty state), e.g., use sortToggle and settlementType as before but branch rendering based on isLoading from useGetSettlementList to avoid the transient empty message.
186-188: 빈 상태 메시지가 현재 선택된 탭에 맞지 않습니다."아직 진행중인 정산이 없어요" 메시지는 "완료된 정산" 탭에서도 동일하게 표시됩니다. 선택된
settlementType에 따라 메시지를 동적으로 변경하는 것이 좋습니다.💡 동적 메시지 제안
<Text variant="body2R" color="semantic.text.subtle"> - 아직 진행중인 정산이 없어요. + {settlementType === 'IN_PROGRESS' + ? '아직 진행중인 정산이 없어요.' + : '완료된 정산이 없어요.'} </Text>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/home/ui/HomePageSection/index.tsx` around lines 186 - 188, The empty-state text inside HomePageSection is hardcoded ("아직 진행중인 정산이 없어요.") and doesn't reflect the current settlementType; update the Text rendering (the Text component in index.tsx within HomePageSection) to compute the message from settlementType (e.g., show "아직 진행중인 정산이 없어요." for in-progress and "아직 완료된 정산이 없어요." for completed) by switching or mapping on settlementType and rendering that dynamic string instead of the static literal.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/features/home/api/useGetSettlementList.ts`:
- Around line 3-5: Prettier is failing because the import and function signature
are on single lines; update the import of SettlementSort and SettlementStatus to
use multi-line named imports and format the useGetSettlementList signature so
its parameters are on separate lines (referencing the import symbols
SettlementSort and SettlementStatus and the function name useGetSettlementList)
so the file conforms to Prettier's multiline rules.
In `@src/pages/home/ui/HomePageSection/index.tsx`:
- Line 168: Prettier is failing on the JSX line that formats createdAt; fix by
applying the project's Prettier formatting to this file or manually adjust the
expression so it matches project style: update the JSX prop using the existing
symbols (format, new Date(item.createdAt), and ko) to a Prettier-compliant form
(for example reformat the line or run prettier --write on the file) so the
date={format(new Date(item.createdAt), 'yyyy년 M월 d일', { locale: ko })}
expression is correctly styled.
---
Nitpick comments:
In `@src/pages/home/ui/HomePageSection/index.tsx`:
- Around line 121-123: The component treats data absence as an empty list,
causing the "no settlements" message to flash during fetch; update the call to
useGetSettlementList(sort) to also read its isLoading (or isFetching) flag and
use that to control UI: keep settlementList = data ?? [] but in the render
branch show a loading indicator/skeleton when isLoading is true (instead of
showing the "정산이 없어요" empty state), e.g., use sortToggle and settlementType as
before but branch rendering based on isLoading from useGetSettlementList to
avoid the transient empty message.
- Around line 186-188: The empty-state text inside HomePageSection is hardcoded
("아직 진행중인 정산이 없어요.") and doesn't reflect the current settlementType; update the
Text rendering (the Text component in index.tsx within HomePageSection) to
compute the message from settlementType (e.g., show "아직 진행중인 정산이 없어요." for
in-progress and "아직 완료된 정산이 없어요." for completed) by switching or mapping on
settlementType and rendering that dynamic string instead of the static literal.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9bbbacb7-baa8-42ae-a450-3be182682557
📒 Files selected for processing (4)
src/entities/group/api/group.tssrc/entities/group/model/group.type.tssrc/features/home/api/useGetSettlementList.tssrc/pages/home/ui/HomePageSection/index.tsx
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
@coderabbitai 코드 추가했는데 리뷰해줘 |
|
✅ Actions performedReview triggered.
|
yoouyeon
approved these changes
Apr 12, 2026
Contributor
yoouyeon
left a comment
yoouyeon
left a comment
There was a problem hiding this comment.
API 연결 작업한 것 확인했습니다! 고생 많으셨습니다 🥹
코드래빗 말대로 prettier를 돌려보니 오류 나는 부분이 있어서 그 부분 수정 부탁드립니당!!
|
|
||
| const payment = { | ||
| getAll: (): Promise<PaymentList> => | ||
| // TODO: 모의 데이터 제거 후 실제 API 연동 시 삭제 useMock: true 옵션 제거 |
Contributor
There was a problem hiding this comment.
이 주석은 더 이상 필요 없다면 제거 부탁드립니다!!
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/home/ui/HomePageSection/index.tsx (1)
178-190:⚠️ Potential issue | 🟡 Minor빈 상태 문구가 선택된 탭과 맞지 않습니다.
COMPLETED탭에서도 항상"아직 진행중인 정산이 없어요."가 보입니다. 선택한settlementType에 맞춰 문구를 바꿔 주세요.🔧 수정 예시
+ const emptyMessage = + settlementType === 'COMPLETED' + ? '아직 완료된 정산이 없어요.' + : '아직 진행중인 정산이 없어요.';<Text variant="body2R" color="semantic.text.subtle"> - 아직 진행중인 정산이 없어요. + {emptyMessage} </Text>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/home/ui/HomePageSection/index.tsx` around lines 178 - 190, The empty-state message always shows "아직 진행중인 정산이 없어요." regardless of the selected settlementType; update the render logic in HomePageSection (where S.NoSettlementImg and the Text with variant="body2R" are rendered) to conditionally choose the copy based on settlementType (e.g., when settlementType === "COMPLETED" show a completed-specific string like "완료된 정산이 없어요." and otherwise show the in-progress string). Ensure the conditional uses the existing settlementType variable (or prop) so the displayed text matches the selected tab.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/entities/payment/api/payment.ts`:
- Line 2: Run the project's formatter/linter to fix Prettier/ESLint issues in
this file: auto-format the import line that references PaymentActionResult and
PaymentList and correct spacing/commas around the type usages elsewhere in the
file (the symbols PaymentActionResult and PaymentList are where the violations
appear). Specifically, apply Prettier formatting and ESLint autofix (e.g. run
the repo's prettier and lint --fix commands) and remove any stray blank lines or
trailing comma/semicolon style mismatches so the file passes CI formatting
rules.
In `@src/pages/home/ui/HomePageSection/index.tsx`:
- Around line 122-123: The current branch uses const { data } =
useGetSettlementList(settlementType, sort) and does const settlementList = data
?? [], which conflates first-load (data undefined), empty-results, and request
failures; update HomePageSection to also destructure isLoading and isError from
useGetSettlementList (e.g., const { data, isLoading, isError } =
useGetSettlementList(...)) and handle three cases explicitly: render a loading
state when isLoading is true, render an error state when isError is true, and
only fall back to an empty array for settlementList when data is defined (const
settlementList = data ?? []). Apply the same change to the other block
referenced (the code around the other useGetSettlementList usage).
In `@src/pages/paymentManagement/PaymentManagementPage.tsx`:
- Around line 81-82: The hooks useApprovePayment and useRejectPayment (whose
mutate aliases are approvePayment and rejectPayment) are called after early
returns and must be moved to the top-level of the PaymentManagementPage
component; relocate the lines "const { mutate: approvePayment } =
useApprovePayment();" and "const { mutate: rejectPayment } =
useRejectPayment();" to the top of the component body (before any isLoading /
isError early returns) so the hooks are always invoked in the same order and
comply with React Hooks rules.
---
Outside diff comments:
In `@src/pages/home/ui/HomePageSection/index.tsx`:
- Around line 178-190: The empty-state message always shows "아직 진행중인 정산이 없어요."
regardless of the selected settlementType; update the render logic in
HomePageSection (where S.NoSettlementImg and the Text with variant="body2R" are
rendered) to conditionally choose the copy based on settlementType (e.g., when
settlementType === "COMPLETED" show a completed-specific string like "완료된 정산이
없어요." and otherwise show the in-progress string). Ensure the conditional uses
the existing settlementType variable (or prop) so the displayed text matches the
selected tab.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 45646d5a-9404-43f9-94e2-f75c3403279f
📒 Files selected for processing (7)
src/entities/payment/api/payment.tssrc/entities/payment/model/payment.type.tssrc/features/home/api/useGetSettlementList.tssrc/features/payment-management/api/useApprovePayment.tssrc/features/payment-management/api/useRejectPayment.tssrc/pages/home/ui/HomePageSection/index.tsxsrc/pages/paymentManagement/PaymentManagementPage.tsx
✅ Files skipped from review due to trivial changes (1)
- src/entities/payment/model/payment.type.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- src/features/home/api/useGetSettlementList.ts
Contributor
Author
|
@coderabbitai 지금 네가 말한 오류들 다 수정했어. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain먼저 기존 리뷰 코멘트들과 최신 코드 상태를 확인할게요! 🏁 Script executed: Length of output: 45217 최신 코드 상태를 확인할게요! 🏁 Script executed: Length of output: 13954
❌ 1. [Critical] React Hooks 규칙 위반 —
|
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/home/ui/HomePageSection/index.tsx (1)
177-188:⚠️ Potential issue | 🟡 Minor빈 상태 문구가 완료 탭과 맞지 않습니다.
COMPLETED탭에서도 항상 “아직 진행중인 정산이 없어요.”가 보여서 선택한 탭과 UI가 어긋납니다. 탭 값에 따라 문구를 바꿔 주세요.🔧 수정 예시
<Text variant="body2R" color="semantic.text.subtle"> - 아직 진행중인 정산이 없어요. + {settlementType === 'COMPLETED' + ? '아직 완료된 정산이 없어요.' + : '아직 진행중인 정산이 없어요.'} </Text>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/home/ui/HomePageSection/index.tsx` around lines 177 - 188, The empty-state message is static and shows "아직 진행중인 정산이 없어요." even when the COMPLETED tab is selected; update the JSX that renders S.NoSettlementImg and the Text (inside HomePageSection index.tsx) to choose the message based on the current tab value (e.g., activeTab, selectedTab, or tab): when tab === 'COMPLETED' show a completed-specific string (e.g., "완료된 정산이 없어요."), otherwise show the in-progress string; implement this conditional display where S.NoSettlementImg and the Text variant="body2R" are rendered.
♻️ Duplicate comments (1)
src/pages/home/ui/HomePageSection/index.tsx (1)
121-122:⚠️ Potential issue | 🟠 Major조회 상태를 빈 목록과 섞지 마세요.
data ?? []만 쓰면 최초 로딩, 탭/정렬 변경 직후 재조회, 요청 실패가 전부 아래 빈 상태로 내려가서 실제 빈 결과처럼 보입니다.useGetSettlementList가 반환하는isLoading/isError를 분기하는 편이 안전합니다.🔧 수정 예시
- const { data } = useGetSettlementList(settlementType, sort); + const { data, isLoading, isError } = useGetSettlementList( + settlementType, + sort, + ); const settlementList = data ?? [];- {settlementList.length > 0 ? ( + {isLoading ? ( + <Flex + direction="column" + py={20} + justifyContent="center" + alignItems="center" + flexGrow={1} + gap={20} + > + <Text variant="body2R" color="semantic.text.subtle"> + 정산 내역을 불러오는 중이에요. + </Text> + </Flex> + ) : isError ? ( + <Flex + direction="column" + py={20} + justifyContent="center" + alignItems="center" + flexGrow={1} + gap={20} + > + <Text variant="body2R" color="semantic.text.subtle"> + 정산 내역을 불러오지 못했어요. + </Text> + </Flex> + ) : settlementList.length > 0 ? (🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/home/ui/HomePageSection/index.tsx` around lines 121 - 122, The component treats data as a simple empty array via "const settlementList = data ?? []", which conflates initial loading, refetching, and error states with a genuine empty result; update the render logic to branch on useGetSettlementList's status flags (useGetSettlementList -> data, isLoading, isError) and only map/use settlementList when isLoading and isError are false (or when isSuccess), while showing a loader or error message during isLoading/isError; keep the fallback empty array only for the confirmed-success case to avoid showing a false-empty state during loading/refetch.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/pages/home/ui/HomePageSection/index.tsx`:
- Line 15: Prettier/ESLint failing because the type import for SettlementSort
and SettlementStatus is on a single line; update the import in index.tsx to
match project formatting by splitting into a multi-line type import (e.g., one
type per line within the import braces) or run the project's auto-formatter so
the import of SettlementSort and SettlementStatus from
'@/entities/group/model/group.type' conforms to the repo prettier rules.
---
Outside diff comments:
In `@src/pages/home/ui/HomePageSection/index.tsx`:
- Around line 177-188: The empty-state message is static and shows "아직 진행중인 정산이
없어요." even when the COMPLETED tab is selected; update the JSX that renders
S.NoSettlementImg and the Text (inside HomePageSection index.tsx) to choose the
message based on the current tab value (e.g., activeTab, selectedTab, or tab):
when tab === 'COMPLETED' show a completed-specific string (e.g., "완료된 정산이
없어요."), otherwise show the in-progress string; implement this conditional
display where S.NoSettlementImg and the Text variant="body2R" are rendered.
---
Duplicate comments:
In `@src/pages/home/ui/HomePageSection/index.tsx`:
- Around line 121-122: The component treats data as a simple empty array via
"const settlementList = data ?? []", which conflates initial loading,
refetching, and error states with a genuine empty result; update the render
logic to branch on useGetSettlementList's status flags (useGetSettlementList ->
data, isLoading, isError) and only map/use settlementList when isLoading and
isError are false (or when isSuccess), while showing a loader or error message
during isLoading/isError; keep the fallback empty array only for the
confirmed-success case to avoid showing a false-empty state during
loading/refetch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0147972b-55ad-4406-9ab0-bb5216e0327b
📒 Files selected for processing (1)
src/pages/home/ui/HomePageSection/index.tsx
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/pages/home/ui/HomePageSection/index.tsx (1)
168-225:⚠️ Potential issue | 🔴 Critical중첩 삼항 연산자로 인해 CI(ESLint
no-nested-ternary)가 실패합니다.파이프라인 로그상 라인 168, 181에서
no-nested-ternary규칙 위반으로 빌드가 실패하고 있습니다.isLoading/isError/ 목록 유무를 세 갈래 중첩 삼항으로 처리하고 있어 린트가 막히므로, 조기 반환(early return) 또는 분기별 변수/함수로 풀어주는 편이 깔끔합니다.🔧 수정 예시 (조기 반환으로 분리)
아래와 같이 리스트 영역만 별도 렌더 함수로 분리하면 중첩 삼항을 제거할 수 있습니다.
+ const renderSettlementList = () => { + if (isLoading) { + return ( + <Flex + direction="column" + py={20} + justifyContent="center" + alignItems="center" + flexGrow={1} + gap={20} + > + <Text variant="body2R" color="semantic.text.subtle"> + 정산 내역을 불러오는 중이에요. + </Text> + </Flex> + ); + } + + if (isError) { + return ( + <Flex + direction="column" + py={20} + justifyContent="center" + alignItems="center" + flexGrow={1} + gap={20} + > + <Text variant="body2R" color="semantic.text.subtle"> + 정산 내역을 불러오지 못했어요. + </Text> + </Flex> + ); + } + + if (settlementList.length > 0) { + return ( + <S.SettlementListWrapper> + {settlementList.map((item) => ( + <HomeExpenseItem + key={item.groupId} + date={format(new Date(item.createdAt), 'yyyy년 M월 d일', { + locale: ko, + })} + groupName={item.name} + totalAmount={item.totalAmount} + paidMember={item.completedMemberCount} + totalMember={item.totalMemberCount} + /> + ))} + </S.SettlementListWrapper> + ); + } + + return ( + <Flex + direction="column" + py={20} + justifyContent="center" + alignItems="center" + flexGrow={1} + gap={20} + > + <S.NoSettlementImg src={CoinImg} alt="" /> + <Text variant="body2R" color="semantic.text.subtle"> + {settlementType === 'IN_PROGRESS' + ? '아직 진행중인 정산이 없어요.' + : '완료된 정산이 없어요.'} + </Text> + </Flex> + ); + }; ... - {isLoading ? ( - <Flex ... > - ... - </Flex> - ) : isError ? ( - ... - ) : settlementList.length > 0 ? ( - ... - ) : ( - ... - )} + {renderSettlementList()}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/home/ui/HomePageSection/index.tsx` around lines 168 - 225, The nested ternary using isLoading / isError / settlementList (rendering the list, empty state, or loading/error UI) violates no-nested-ternary; refactor the JSX in HomePageSection by extracting the conditional block into either early returns or a separate render function/variable (e.g., renderSettlementList()) that returns the loading UI (uses isLoading), error UI (uses isError), the mapped HomeExpenseItem list (uses settlementList.map and format, groupId, createdAt, etc.), or the empty state (uses settlementType, S.NoSettlementImg, CoinImg); replace the nested ternary with simple if/return branches or a switch inside that function so ESLint no longer reports nested ternaries.
🧹 Nitpick comments (1)
src/pages/home/ui/HomePageSection/index.tsx (1)
27-27: 불필요한 타입 별칭은 제거를 고려해 주세요.
type SettlementType = SettlementStatus;는 단순 재명명일 뿐이라, 상태 변수와 핸들러에서 바로SettlementStatus를 사용하는 편이 타입 소스의 일관성과 탐색성에 더 유리합니다. 별칭이 필요한 도메인적 의미 차이가 없다면 제거하는 것을 권장합니다.♻️ 제안
-type SettlementType = SettlementStatus; - export function MainHeader() { ... - const [settlementType, setSettlementType] = - useState<SettlementType>('IN_PROGRESS'); + const [settlementType, setSettlementType] = + useState<SettlementStatus>('IN_PROGRESS'); ... - const handleSettlementTypeButtonClick = (type: SettlementType) => { + const handleSettlementTypeButtonClick = (type: SettlementStatus) => {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/pages/home/ui/HomePageSection/index.tsx` at line 27, Remove the redundant type alias `SettlementType = SettlementStatus` and update all references to `SettlementType` in this module (state declarations, handlers, props, and any function signatures) to use `SettlementStatus` directly; ensure imports/export names remain consistent and run TypeScript to fix any remaining type errors caused by the rename.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/pages/home/ui/HomePageSection/index.tsx`:
- Around line 168-225: The nested ternary using isLoading / isError /
settlementList (rendering the list, empty state, or loading/error UI) violates
no-nested-ternary; refactor the JSX in HomePageSection by extracting the
conditional block into either early returns or a separate render
function/variable (e.g., renderSettlementList()) that returns the loading UI
(uses isLoading), error UI (uses isError), the mapped HomeExpenseItem list (uses
settlementList.map and format, groupId, createdAt, etc.), or the empty state
(uses settlementType, S.NoSettlementImg, CoinImg); replace the nested ternary
with simple if/return branches or a switch inside that function so ESLint no
longer reports nested ternaries.
---
Nitpick comments:
In `@src/pages/home/ui/HomePageSection/index.tsx`:
- Line 27: Remove the redundant type alias `SettlementType = SettlementStatus`
and update all references to `SettlementType` in this module (state
declarations, handlers, props, and any function signatures) to use
`SettlementStatus` directly; ensure imports/export names remain consistent and
run TypeScript to fix any remaining type errors caused by the rename.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6f7ec524-d6f0-4967-8ca7-b9f9b6765218
📒 Files selected for processing (4)
.claude/settings.local.jsonsrc/entities/payment/api/payment.tssrc/pages/home/ui/HomePageSection/index.tsxsrc/pages/paymentManagement/PaymentManagementPage.tsx
✅ Files skipped from review due to trivial changes (1)
- .claude/settings.local.json
🚧 Files skipped from review as they are similar to previous changes (2)
- src/pages/paymentManagement/PaymentManagementPage.tsx
- src/entities/payment/api/payment.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SettlementGroup타입 및SettlementSort,SettlementStatus타입 추가getSettlementList(status, sort, limit)API 함수 추가 (GET /api/v1/groups)useGetSettlementListhook 추가PaymentActionResult타입 및 입금 승인/거절 API 함수 추가 (PATCH /api/v1/payments/{id}/approve|reject)useApprovePayment,useRejectPaymenthook 추가Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
새로운 기능
스타일/콘텐츠