[game] Make save and runtime lifetimes explicit - #342
Open
Eldbury wants to merge 27 commits into
Open
Conversation
Keep live runtime object IDs separate from the authoritative IDs carried by a saved module graph. Restore saved references through a per-module translation registry, preserve runtime-created references through the live registry, and emit every snapshot reference through one object-based ID allocation context. This prevents detached record IDs and coincident runtime numbers from binding to the wrong object, covers structural module references and nested effect/action/event references, and retains deterministic snapshot allocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes identity and runtime-lifetime boundaries explicit across module transitions and save restoration. Serialized object identity, Party roster identity, Area residency, runtime incarnation, and owned-object relationships are now represented independently instead of being inferred from numeric IDs, Tags, registry presence, or storage lifetime.
Save and module loading now separate fallible resource and structural preparation from irreversible session publication. Runtime objects and owned graphs publish only after their identity, construction, and ownership are coherent, while failed restoration retires partial state without exposing an invalid gameplay session.
Party continuation, object references, inventory/equipment ownership, Creature vitality, and K1/K2 save compatibility found during validation follow the same model. The lifecycle and failure contracts are documented in
doc/e-series-loader-lifecycle.md.Validation