Skip to content

chore: fix ginkgolinter issues #3273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Jul 30, 2026
Merged

chore: fix ginkgolinter issues #3273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@ run:
linters:
default: none
enable:
- misspell
- ginkgolinter
- govet
- ineffassign
- misspell
- modernize
- revive
- unconvert
- unused
- govet
settings:
govet:
enable:
Expand Down
2 changes: 1 addition & 1 deletion manager/csi/plugin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ var _ = Describe("Plugin manager", func() {
})

It("should not call CreateVolume", func() {
Expect(controller.createVolumeRequests).To(HaveLen(0))
Expect(controller.createVolumeRequests).To(BeEmpty())
})

It("should not return an error", func() {
Expand Down
2 changes: 1 addition & 1 deletion manager/orchestrator/jobs/replicated/reconciler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ var _ = Describe("Replicated Job reconciler", func() {

It("should use the cluster to set the default log driver", func() {
tasks := AllTasks(s)
Expect(len(tasks) >= 1).To(BeTrue())
Expect(tasks).ToNot(BeEmpty())

Expect(tasks[0].LogDriver).To(Equal(cluster.Spec.TaskDefaults.LogDriver))
})
Expand Down