fix(memory): enforce readonly mode across writes - #119
Merged
Conversation
Open SQLite through an immutable read-only URI, reject mutating CLI paths with an actionable error, and document snapshot semantics. Add regression coverage for rejected writes, successful reads, unchanged data, and absent WAL sidecars. Validated with focused store and command tests, an end-to-end readonly reproduction, and make test.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--readonlyreject every CLI path that can mutate memory or store selectionmode=ro&immutable=1file URIThe write gates cover
remember,forget,link, non-dry-runimport, mutatingembedmodes,gc --keep, and store create/set/remove. Read-only paths do not create WAL/SHM sidecars, including when the database path contains spaces.Verification
--readonly rememberexited 0 and increased the row countgit diff --checkmake testCloses #102.