CLI: stop the bare gps command crashing when no GPS was detected - #14
Open
mmmorks wants to merge 1 commit into
Open
CLI: stop the bare gps command crashing when no GPS was detected#14mmmorks wants to merge 1 commit into
gps command crashing when no GPS was detected#14mmmorks wants to merge 1 commit into
Conversation
The status branch does strcmp(_sensors->getSettingByKey("gps"), "1").
getSettingByKey() returns NULL when no "gps" setting is registered, which is
the case whenever gps_detected was false at boot, and strcmp() then
dereferences it.
Treat a missing setting as "deactivated".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The status branch of the
gpscommand does:getSettingByKey()returnsNULLwhen nogpssetting is registered, which is the case whenevergps_detectedwas false at boot — sostrcmp()dereferences a null pointer and the node crashes.Treat a missing setting as "deactivated".
Reproducing
Send
gpsto any node built withENV_INCLUDE_GPSwhose GPS was not detected at startup.How it was tested
pio test -e native: all suites pass.meshnology_w12_repeater(ESP32-S3).Dependencies
Independent. Applies to
dev.