Repository navigation
qt: fix selective title gradients and add per-selection shadows - #1348
Merged
j-b-m merged 4 commits intoOct 27, 2026
Merged
Conversation
Match Kdenlive's QTextLayout-based range geometry for selective title gradients. Keep legacy whole-object gradients and existing saved metadata compatible, including typewriter rendering. Add image regressions for positioned ranges, multiple styles, alignment, multiline and bidi text. Relevant native MLT suites passed.
Read validated per-character shadow overrides while preserving legacy object shadows. Match Kdenlive's glyph, decoration and outline masks, including bidi text, transparency, mixed fonts and typewriter reveals. Advertise the new capability through producer version 9. Add native image, metadata and typewriter regressions. Relevant native MLT suites passed; 192 legacy frame comparisons were byte-identical.
Preserve selective gradient and shadow rendering across platforms, keep backend-dependent tests explicit, and complete source attribution. Validated locally with stock Qt 6.11.2 before publication preparation. Fresh post-rebase Linux validation is required before pushing.
j-b-m
reviewed
Oct 22, 2026
j-b-m
left a comment
j-b-m
left a comment
Contributor
There was a problem hiding this comment.
Minor change request, otherwise the changes pass our test suite so I think should be good
j-b-m
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix selective gradients so the full color transition covers the formatted text range independently of neighboring text.
Add selection-only shadows with save/reopen persistence and matching typewriter rendering. Preserve existing whole-object gradient and shadow behavior, and increase the kdenlivetitle producer capability from 8 to 9.
Also make shadow masks consistent across raster targets and add rendering regression tests.
Companion Kdenlive MR:
https://invent.kde.org/multimedia/kdenlive/-/merge_requests/1056
Validation:
The separate Qt outline fix is not included or required.