Repository navigation
Compute summarizer scores after the RCP check updates scaling.json - #484
Open
matthew-frank wants to merge 1 commit into
Open
matthew-frank wants to merge 1 commit into
matthew-frank wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The summarizer was trying to read scaling.json before creating it, so behavior was dependent on whether there was a previous run of the summarizer or not. This had strange consequences at submission time where some submitters submitted a tarball created after running the summarizer (so had scaling.json) while other submitters had tarballs without scaling.json, so the scores in the initial table were inconsistent. Some scaled some not.
this change generates scaling.json before trying to read it.
we also add a check to rcp_checker so that if a non-unity scaling factor is going to change a warning is emitted.