Conversation
Filter out authoring queue entries with status 'deferred' in tools/check-duplicates.py analyze_repository function to prevent false-positive duplicate collision failures on inactive items. Co-authored-by: mjmirza <34001140+mjmirza@users.noreply.github.com> Co-authored-by: mjmirza <34001140+mjmirza@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Duplicate Risk Demonstrated & Real Examples
Running
python3 tools/check-duplicates.py --checkonmainfails with exit code 1 becausepatterns/24-stream-processing/windowing.mdindocs/AUTHORING-QUEUE.jsonis flagged as a collision against the publishedpatterns/13-frontend-ui/virtual-list.mdentry via the alias term "Windowing".However,
windowingindocs/AUTHORING-QUEUE.jsonis explicitly marked with"status": "deferred". Deferred items are tracked for context but are inactive and excluded from authoring targets.Exact Failure Mode & Fix
tools/check-duplicates.pypreviously parsed all items indocs/AUTHORING-QUEUE.jsonwithout filtering bystatus. This PR updatesanalyze_repository()to filter out queue entries wherestatus == "deferred".Test Coverage & Verification
test_deferred_queue_filteringintools/check-duplicates-test.pyto verify deferred queue items are excluded while active candidate duplicate items are correctly flagged.--checkand--strictexit code modes.python3 tools/check-duplicates-test.py(all 12 unit tests pass).python3 tools/check-duplicates.py --checkandpython3 tools/check-duplicates.py --strictreturn exit code 0.Confidence Score
Total: 100/100
PR created automatically by Jules for task 13281155648538548014 started by @mjmirza