Conversation
Filter out authoring queue entries with status 'deferred' in tools/check-duplicates.py analyze_repository function to prevent false-positive duplicate collision failures on inactive items. Co-authored-by: mjmirza <34001140+mjmirza@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Filter out queue entries with
status == "deferred"intools/check-duplicates.pyduring duplicate analysis. Inactive or permanently deferred entries indocs/AUTHORING-QUEUE.jsonpreviously triggered false-positive queue collision errors against published patterns and caused strict duplicate checks (--strict/--check/make duplicates) to fail onmain.Details & Verification
windowingindocs/AUTHORING-QUEUE.json) are on-hold/deferred items that are not active candidates for authoring. When checked against published entries (e.g.virtual-list.md), they produced false-positive collision alerts.patterns/24-stream-processing/windowing.mdindocs/AUTHORING-QUEUE.jsonis marked"status": "deferred". Before this fix,python3 tools/check-duplicates.py --checkfailed with aQUEUE COLLISIONerror againstpatterns/13-frontend-ui/virtual-list.md.AUTHORING-QUEUE.jsonrecord human governance decisions. Checking them as active queue items incorrectly flags known deferred decisions.tools/check-duplicates.py) normalizing terms and checking queue vs published and historical commits.docs/AUTHORING-QUEUE.jsonloaded deferred entries as active queue candidates.q.get("status") != "deferred"inanalyze_repository, aligning duplicate detection withnext-batch.pyqueue conventions.tools/check-duplicates-test.py.tools/check-duplicates.pyandtools/check-duplicates-test.py.12 tests in check-duplicates-test.py passed OK; make test passed 22 tests OK.tools/check-duplicates.pyandtools/check-duplicates-test.py.PR created automatically by Jules for task 10706301809477118493 started by @mjmirza