Conversation
…ily-names.py The family folder naming gate `tools/check-family-names.py` previously verified that every directory on disk under `patterns/` was declared in `README.md`'s `## The families` table, but omitted the reverse check. If a family declared in the canonical `README.md` table was deleted or missing from disk, `verify_family_names()` silently passed. This update enforces bidirectional consistency by checking that every family slug declared in `README.md`'s `## The families` table exists as a directory under `patterns/`. A new unit test `test_verify_family_names_missing_directory_declared_in_readme` is added to `tools/check-family-names-test.py` to cover this failure mode. Co-authored-by: mjmirza <34001140+mjmirza@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes false-negative gate in
tools/check-family-names.pyby ensuring bidirectional verification betweenREADME.md's## The familiestable andpatterns/family directories on disk. Adds corresponding unit test intools/check-family-names-test.py.PR created automatically by Jules for task 7842379861904987670 started by @mjmirza