Skip to content

Make run(.no_wait) collect finished I/O on IOCP #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
endel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make run(.no_wait) collect finished I/O on IOCP #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion src/backend/iocp.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,10 +313,12 @@ pub const Loop = struct {
}

// If we have processed enough event, we break out of the loop.
if (wait_rem == 0) break;
if (wait > 0 and wait_rem == 0) break;

// Determine our next timeout based on the timers.
const timeout: ?windows.DWORD = timeout: {
if (wait == 0) break :timeout 0;

// If we have a timer, we want to set the timeout to our next timer value. If we
// have no timer, we wait forever.
const t = self.timers.peek() orelse break :timeout null;
Expand Down Expand Up @@ -2278,6 +2280,54 @@ test "iocp: socket accept/connect/send/recv/close" {
try testing.expect(client_conn_closed);
}

test "iocp: no_wait collects what the kernel has finished" {
const testing = std.testing;

var loop = try Loop.init(.{});
defer loop.deinit();

const address = try net.Address.parseIp4("127.0.0.1", 3132);
const socket = try windows.WSASocketW(windows.ws2_32.AF.INET, windows.ws2_32.SOCK.DGRAM, windows.ws2_32.IPPROTO.UDP, null, 0, windows.ws2_32.WSA_FLAG_OVERLAPPED);
defer iocpClose(socket);
try iocpBind(asSocket(socket), &address.any, address.getOsSockLen());

var received: ?ReadError!usize = null;
var buf: [8]u8 = undefined;
var c: Completion = .{
.op = .{ .recvfrom = .{ .fd = socket, .buffer = .{ .slice = &buf } } },
.userdata = &received,
.callback = (struct {
fn callback(ud: ?*anyopaque, _: *Loop, _: *Completion, r: Result) CallbackAction {
const out: *?ReadError!usize = @ptrCast(@alignCast(ud.?));
out.* = r.recvfrom;
return .disarm;
}
}).callback,
};
loop.add(&c);
try loop.run(.no_wait);
try testing.expect(received == null);

const sender = try windows.WSASocketW(windows.ws2_32.AF.INET, windows.ws2_32.SOCK.DGRAM, windows.ws2_32.IPPROTO.UDP, null, 0, windows.ws2_32.WSA_FLAG_OVERLAPPED);
defer iocpClose(sender);
const Os = struct {
extern "kernel32" fn Sleep(ms: u32) callconv(.winapi) void;
extern "ws2_32" fn sendto(s: windows.ws2_32.SOCKET, buf: [*]const u8, len: i32, flags: i32, to: *const posix.sockaddr, to_len: i32) callconv(.winapi) i32;
};
try testing.expectEqual(4, Os.sendto(asSocket(sender), "ping", 4, 0, &address.any, @intCast(address.getOsSockLen())));

// Loopback delivery isn't synchronous, so this gives it time, without
// ever letting the loop block.
for (0..1000) |_| {
try loop.run(.no_wait);
if (received != null) break;
Os.Sleep(1);
}
try testing.expect(received != null);
try testing.expectEqual(4, try received.?);
try testing.expectEqualStrings("ping", buf[0..4]);
}

test "iocp: recv cancellation" {
const mem = std.mem;
const testing = std.testing;
Expand Down