Repository navigation
Conversation
bvolpato
marked this pull request as ready for review
October 28, 2026 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let applications waiting on non-storage events opt out of Linux I/O-wait accounting for blocking io_uring waits. Keep the existing default policy.
Related to #216. The opt-in, feature-gated policy follows the existing reproductions and the October 21 proposal. This implements that policy on current Zig 0.17 main.
Impact
GETEVENTS(0x1)GETEVENTS(0x1)GETEVENTS(0x1)Nonblocking paths keep their existing behavior. This changes accounting policy. Application latency, throughput, and power benefits have not been established.
Changes
Add the io_uring-specific
no_iowaitoption, defaulting to false. Gate the flag on a positive wait andIORING_FEAT_NO_IOWAIT(Linux 6.15+), covering both combined submit/wait and waits after submission overflow. No Ghostty adoption or C API change is included.Testing
zig build test -Demit-man-pages=false -j2 --summary allpassed on Linux x86_64 with Zig 0.17.Upstream CI awaits maintainer approval for this fork's workflow.