Change edition and style_edition to 2024 in rustfmt.toml#2050
Open
ImplOfAnImpl wants to merge 1 commit intoupdate_rust_editionfrom
Open
Change edition and style_edition to 2024 in rustfmt.toml#2050ImplOfAnImpl wants to merge 1 commit intoupdate_rust_editionfrom
edition and style_edition to 2024 in rustfmt.toml#2050ImplOfAnImpl wants to merge 1 commit intoupdate_rust_editionfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be precise, I removed
style_editioncompletely, in which case it defaults toedition.Most of the changes come from reordering of imports. These are not super useful, but there is no option to keep imports as they were, while having all other 2024 changes.
There are a few places where the code became a bit nicer-looking, e.g.
became
and
became
In general, it seems to format macro calls better now.
Also, they fixed a bug where a long string literal would cause the entire expression to not be formatted at all. (Though I'm not sure if it applies to all cases, e.g. in the past having an extra long string could break rustfmt completely, so that it wouldn't format anything in the whole file. No idea if this was fixed or not.)
But there are also places where it became uglier, e.g.
became
But overall IMO the code looks better, so I'd say let's upgrade.