Repository navigation
fix(compile): advance contiguous gradient inputs with reduce-scatter - #1309
Merged
Merged
Conversation
honghaowang25
requested review from
kisnwangg and
yu-chen-code
as code owners
October 27, 2026 07:23
Contributor
Author
|
/check-pr |
Contributor
Author
|
/retest |
|
|
@honghaowang25, your gate pipeline failed at the code check stage. You can configure some code check tools locally following the (pre-push quick guide), to enable automatic checking when you push your code every time. Tools included are: Check_CMakelint, Check_Codespell, Check_Cpplint, Check_Lizard, Check_Pylint, Check_ClangFormat, Check_ShellCheck. |
Contributor
Author
|
/retest |
Keep NPU reduce-scatter inputs contiguous while emitting schema-backed backward preparation owned by each reduction. Move private preparation with its launch so layout conversion no longer pins communication at the graph tail. Preserve dependency, effect and storage-release boundaries. Add regressions for private and shared preparation, ownership, mutations, alias releases and repeated scheduling. Retain strict loss/gradient checks and the requirement for real reduce-scatter movement. Validation: 68 FSDP/overlap tests on Torch 2.9.0 CPU; 247 compile tests on the current runtime; CI Pylint 3.3.7 rates both production files 10.00/10.
Contributor
Author
|
/retest |
|
|
kisnwangg
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired: GitHub #1309 ↔ GitCode !1848
What type of PR is this?
/kind bugfix
What does this PR do / why do we need it:
Keep NPU reduce-scatter inputs contiguous while emitting schema-backed backward preparation owned by each reduction. Move private preparation with its launch so layout conversion no longer pins communication at the graph tail. Preserve dependency, effect and storage-release boundaries.
Add regressions for private and shared preparation, ownership, mutations, alias releases and repeated scheduling. Retain strict loss/gradient checks and the requirement for real reduce-scatter movement.
Which issue(s) this PR fixes:
Fixes #1311
Code review checklist [illustration]: