Repository navigation
Conversation
nepdada
requested review from
suteng,
yangzhenzhang02 and
yaoyifanx
as code owners
October 20, 2026 03:06
nepdada
commented
Oct 21, 2026
wangyin888
reviewed
Oct 21, 2026
| # ----------------------------------------------------------------------------------------------------------- | ||
|
|
||
| set -euo pipefail | ||
| set -xeuo pipefail |
Contributor
Author
|
/retest_hyper |
Contributor
Author
|
/retest_hyper |
|
Contributor
Author
|
/retest_hyper |
|
|
Contributor
Author
|
/retest_hyper |
4 tasks done
Contributor
Author
|
/retest_hyper |
1 similar comment
Contributor
Author
|
/retest_hyper |
|
|
|
|
Contributor
Author
|
/retest_hyper |
|
|
Contributor
Author
|
/retest |
|
Gate trigger failed: please fix the /check-pr findings and obtain the |
Contributor
Author
|
/check-pr |
Contributor
Author
|
/retest |
|
|
|
|
Contributor
Author
|
/retest_hyper |
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired: GitHub #1239 ↔ GitCode !1822
What type of PR is this?
/kind task
What does this PR do / why do we need it:
修复
test_semantic_difference_documentation在新版本环境下的失败。背景:该测试原先在 CANN 9.1 + MindSpore 2.10 环境下稳定通过,升级到
CANN 9.2 + MindSpore 2.11 后,原断言开始出现误差导致失败。
原因:测试用
assertEqual断言 Megatron 的 full-softmax 概率和精确等于num_tokens,但 float32 下对num_tokens * num_experts个 softmax 概率求和必然存在舍入误差。新版本 CANN / MindSpore 的算子实现与累加顺序变化,
使该舍入误差显现出来(本次观测到 ~7.6e-6),精确相等不再成立。
本 PR:
assertEqual改为assertAlmostEqual(..., delta=1e-5),容忍 fp32 舍入误差;
HyperParallel(仅 top-k)求和严格小于 num_tokens。
Which issue(s) this PR fixes:
Fixes #341
Code review checklist [illustration]: