Skip to content

✨ add support for custom httpx client for V1 and V2#415

Open
sebastianMindee wants to merge 6 commits into
release/v5.0.0a1from
add-custom-client
Open

✨ add support for custom httpx client for V1 and V2#415
sebastianMindee wants to merge 6 commits into
release/v5.0.0a1from
add-custom-client

Conversation

@sebastianMindee

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

@sebastianMindee sebastianMindee requested a review from ianardee June 8, 2026 13:36

@ianardee ianardee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for a single call, but what happens when multiple calls are made?

Also:

  • what happens to the client, does it close by itself, does the user need to close it?
  • does threading still work now that the client is a class variable?

More explicit testing of failure points need to be added.

@sebastianMindee

sebastianMindee commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

what happens to the client, does it close by itself, does the user need to close it?

Good point, I had forgotten to add the garbage collection. Also, if they aren't using a context manager they have to manage it themselves, but not much we can do.

does threading still work now that the client is a class variable?

Yes: encode/httpx#1633

More explicit testing of failure points need to be added.

Did so, tell me if you think more are warranted

@sebastianMindee sebastianMindee requested a review from ianardee June 8, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants