MOBILE-106: Fix iOS New Architecture guard and Swift header import#171
Merged
sergeysozinov merged 1 commit intonew-archfrom Apr 30, 2026
Merged
MOBILE-106: Fix iOS New Architecture guard and Swift header import#171sergeysozinov merged 1 commit intonew-archfrom
sergeysozinov merged 1 commit intonew-archfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes iOS build-time guards/imports so the Mindbox React Native module reliably compiles only with the New Architecture enabled and can find the generated Swift bridging header across different CocoaPods header layouts.
Changes:
- Update the New Architecture preprocessor guard to fail the build when
RCT_NEW_ARCH_ENABLEDis missing or not set to1. - Make the Swift generated header import resilient by trying both local and module-style include paths, with a clearer compile-time error if missing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ios/MindboxSdkNewArchGuard.mm | Tightens the compile-time guard to enforce RCT_NEW_ARCH_ENABLED=1. |
| ios/MindboxSdk.mm | Adds __has_include-based fallback imports for MindboxSdk-Swift.h (local vs modular). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
justSmK
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-106