Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for a separate “operations domain” (optionally coming from remote mobile config) so the SDK can route operations endpoints through a different host (e.g., anonymizer/proxy) while keeping backward compatibility with the existing domain.
Changes:
- Extend config/DTO parsing to read
settings.baseAddresses.operationsand persist it in SharedPreferences. - Add
operationsDomainto SDK init configuration + RoomConfigurationentity, and route operations URLs through the resolved domain with a priority chain. - Update/expand unit tests for domain parsing/normalization and operations-domain routing behavior.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/src/test/java/cloud/mindbox/mobile_sdk/managers/MobileConfigSettingsManagerTest.kt | Updates test construction for SettingsDto with new field. |
| sdk/src/test/java/cloud/mindbox/mobile_sdk/managers/GatewayManagerTest.kt | Adds tests for operations-domain resolution and URL routing. |
| sdk/src/test/java/cloud/mindbox/mobile_sdk/inapp/data/repositories/OperationsDomainConfigPolicyTest.kt | New tests for config → stored-domain persistence policy. |
| sdk/src/test/java/cloud/mindbox/mobile_sdk/SdkValidationDomainTest.kt | New tests for domain normalization helpers (extractHost, toBaseUrl). |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/repository/MindboxPreferences.kt | Adds operationsDomainFromConfig stored preference. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/repository/MindboxDatabase.kt | Bumps Room DB version and adds migration for operationsDomain column. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/models/operation/response/InAppConfigResponse.kt | Adds baseAddresses.operations to config DTOs. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/models/Configuration.kt | Adds operationsDomain field to persisted init configuration model. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/managers/GatewayManager.kt | Routes operations endpoints via resolved operations domain; normalizes base URLs. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/repositories/OperationsDomainConfigPolicy.kt | Introduces policy for deciding whether to save/keep/clear stored operations domain. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/repositories/MobileConfigRepositoryImpl.kt | Parses baseAddresses and persists operations domain based on policy. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/managers/MobileConfigSerializationManagerImpl.kt | Parses baseAddresses block from settings JSON. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/SdkValidation.kt | Adds helpers for domain normalization + validates optional operationsDomain. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/MindboxConfiguration.kt | Adds builder/config support for operationsDomain. |
| sdk/src/main/java/cloud/mindbox/mobile_sdk/Mindbox.kt | Integrates operationsDomain into init validation and sanitization flow. |
| sdk/src/androidTest/java/cloud/mindbox/mobile_sdk/InputParametersUnitTest.kt | Updates validation expectations for normalized domain inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1656c8b to
7af9213
Compare
7af9213 to
d797449
Compare
sergeysozinov
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-129