Repository navigation
Fix the ValidationError snippet in the Core README - #180
Merged
Merged
Conversation
The "failed result" example called a ValidationError constructor that doesn't exist, so it didn't compile; it moved from the root README into the packed Core README in #99. It now uses the real constructor, with a camelCase rule name like the library's validators and no value, so no identifier lands in the error's metadata (ADR-0003). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Matches the library's validators (topCount, iso4217, ...). The previous commit's edit was skipped by a case-insensitive check in my script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162
The "failed result" example called
new ValidationError("NIP is invalid."), butValidationErrorhas one constructor,(message, ruleName, name, value), so the snippet didn't compile. #99 (PR #170) moved it from the root README intosrc/OpenUrzednik.Core/README.mdandREADME.pl.md; the Core README is packed, so the broken example also showed on nuget.org. That was my mistake in #99: I compiled only the NBP quick start, not this example.Now:
new ValidationError("NIP is invalid.", ruleName: "nipChecksum", name: "nip", value: null)in both files (the same code, ADR-0009). The rule name is camelCase like the library's validators (topCount,iso4217, …), and the value staysnull, so no identifier lands in the error's metadata (ADR-0003).Checks
src/OpenUrzednik.Core(net10.0); the EN and PL snippets are byte-identical; the fixed example runs and prints "NIP is invalid." fromOpenUrzednikValidationException.git grepfinds no other error constructor in any README.🤖 Generated with Claude Code